[CI] Prepare for 3.8.0-RC1 release #24422
Merged
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
added
the
backport:nominated
tgodzik
approved these changes
Nov 13, 2025
|
|
||
| publish-winget: | ||
| uses: ./.github/workflows/publish-winget.yml | ||
| if: false # TODO: Requires setting up initial WinGet package |
Contributor
There was a problem hiding this comment.
Didn't this work previously?
…expose implementation detail in POM metadata
hamzaremmal
reviewed
Nov 13, 2025
| .dependsOn(`scala3-interfaces`, `tasty-core-bootstrapped-new`, `scala3-library-bootstrapped-new`) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-compiler-bootstrapped", |
Member
There was a problem hiding this comment.
these are not necessary to remove, the moduleName two lines below is what defines the name of the artifact. We should keep these to know in sbt if we manipulate a bootstrapped project or a on-bootstrapped project.
Contributor
Author
There was a problem hiding this comment.
Yes, but these are later exposed publicly as attributes in POM https://repo1.maven.org/maven2/org/scala-lang/scala3-compiler_3/3.7.4/scala3-compiler_3-3.7.4.pom - see both name and description
The non-bootstrapped projects have the nonbootstrapped suffix, so it should be fine
Member
There was a problem hiding this comment.
I'll accept this PR assuming that the non-bootstrapped projects are label.
hamzaremmal
reviewed
Nov 13, 2025
| fi | ||
| - name: Prepare the SDKs | ||
| shell: bash |
Member
There was a problem hiding this comment.
We don't have the binaries yet.
hamzaremmal
reviewed
Nov 13, 2025
| - name: Download MSI package | ||
| uses: actions/download-artifact@v6 | ||
| with: | ||
| name: scala.msi |
Member
There was a problem hiding this comment.
and we don't have the msi yet
…need to expose implementation detail in POM metadata" This reverts commit b340f1c.
WojciechMazur
added a commit
that referenced
this pull request
Nov 13, 2025
Prepare for releasing 3.8.0-RC1 artifacts by adjusting how artifacts are published. We don't introduce a full refactor by switching to use dedicated environments and `release-maven-artifacts` workflow yet. Instead we're only adjusting existing, battle-tested workflow to publish artifacts using new variants of projects to reduce risks due too many moving parts. The CI refactor would be introduced for 3.8.1 releases after testing it first on nightlies in a full workflow (including execution of tests which is now missing) Additional minor adjustments: - disable publishing to WinGet - this workflow has never succeeded and requires creation of first release manually - Switch homepage from GitHub repository to `scala-lang.org` website [Cherry-picked 7a0d2be]
WojciechMazur
added
backport:accepted
WojciechMazur
added a commit
that referenced
this pull request
Nov 13, 2025
Backports #24422 to the 3.8.0-RC1. PR submitted by the release tooling.
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for releasing 3.8.0-RC1 artifacts by adjusting how artifacts are published.
We don't introduce a full refactor by switching to use dedicated environments and
release-maven-artifactsworkflow yet. Instead we're only adjusting existing, battle-tested workflow to publish artifacts using new variants of projects to reduce risks due too many moving parts.The CI refactor would be introduced for 3.8.1 releases after testing it first on nightlies in a full workflow (including execution of tests which is now missing)
Additional minor adjustments:
scala-lang.orgwebsite